Fix .dropdown-item border-radius when $dropdown-padding-y is 0
#36447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomONeill
reviewed
Aug 8, 2022
| @@ -66,6 +66,18 @@ | |||
| left: 0; | |||
| margin-top: var(--#{$prefix}dropdown-spacer); | |||
| } | |||
|
|
|||
| @if $dropdown-padding-y == 0 { | |||
| > .dropdown-item:first-child, | |||
There was a problem hiding this comment.
Late to the party, but .dropdown-menu > li isn't right, there's usually an anchor (<a>) tag in between.
Shall we just skip the >?
There was a problem hiding this comment.
@mdo I'm sure you get auto-tagged, but just in case you don't.
There was a problem hiding this comment.
Hey @mdo, my last comment didn't make sense I just realised. But I do have a scenario where the fix doesn't work:
<ul class="dropdown-menu">
<div style="max-height: 400px">
<li><a class="dropdown-item" href="#">Menu item</a></li>
<li><a class="dropdown-item" href="#">Menu item</a></li>
<li><a class="dropdown-item" href="#">Menu item</a></li>
</div>
</ul>If we'd get rid of the > selector, I think it will work in these cases too.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36329.