Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix Reboot Horizontal rules using border utilities #36476

Merged
merged 1 commit into from Jun 1, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jun 1, 2022

In the current main branch we can see in Reboot > Horizontal rules that all borders have the same thickness, event with .border-2 and .border-3.

This PR proposes to add .border for .border-3 and .border-3 to be actually applied.

It also means that we can't use anymore .text-danger but replace it by .border-danger due to the use of CSS vars.

I believe that the description associated with this example is still accurate but I'd appreciate a double-check.

Live preview

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mdo mdo added this to In progress in v5.2.0-stable via automation Jun 1, 2022
@mdo mdo force-pushed the main-jd-fix-reboot-hr-with-border-utilities branch from f523522 to 4c0027f Compare June 1, 2022 20:36
@mdo mdo merged commit 29766b2 into main Jun 1, 2022
v5.2.0-stable automation moved this from In progress to Done Jun 1, 2022
@mdo mdo deleted the main-jd-fix-reboot-hr-with-border-utilities branch June 1, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants