Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix some ARIA Authoring Practices Guides broken links #36488

Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jun 2, 2022

This PR fixes some ARIA Authoring Practices Guides broken links found in the documentation and tries to improve consistency in the text of those links.

I don't have access to the previous content so I'm not 100% sure that the modification is well https://www.w3.org/TR/wai-aria-practices/#somethinghttps://www.w3.org/WAI/ARIA/apg/patterns/something/.

Feel free to comment or directly modify the links.

Note: if merged would need to be backported to v4

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review June 2, 2022 20:17
@patrickhlauke
Copy link
Member

Ah, good point ... I spotted an old link earlier while looking at #36487 and then promptly forgot...

Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry last nitpick

site/content/docs/5.2/components/navs-tabs.md Outdated Show resolved Hide resolved
site/content/docs/5.2/components/navs-tabs.md Outdated Show resolved Hide resolved
@patrickhlauke patrickhlauke merged commit 6d5a703 into main Jun 2, 2022
@patrickhlauke patrickhlauke deleted the main-jd-fix-aria-authoring-practices-guide-broken-links branch June 2, 2022 21:10
@patrickhlauke patrickhlauke added this to In progress in v5.2.0-stable via automation Jun 2, 2022
@twbs twbs deleted a comment from romodog Jun 3, 2022
mwszekely pushed a commit to mwszekely/bootstrap that referenced this pull request Jun 8, 2022
* Docs: fix some ARIA Authoring Practices Guides broken link
@GeoSot GeoSot moved this from In progress to Done in v5.2.0-stable Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants