Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customize/sass.md doc doubt/typo? #36534

Closed
3 tasks done
pine3ree opened this issue Jun 9, 2022 · 2 comments · Fixed by #36535
Closed
3 tasks done

customize/sass.md doc doubt/typo? #36534

pine3ree opened this issue Jun 9, 2022 · 2 comments · Fixed by #36535

Comments

@pine3ree
Copy link
Contributor

pine3ree commented Jun 9, 2022

Prerequisites

Describe the issue

the best position for altering maps

Reduced test cases

In the Remove from map section https://github.com/twbs/bootstrap/blob/main/site/content/docs/5.2/customize/sass.md#remove-from-map, shouldn't the _root.scss import be placed after altering default maps, since it is using the defined maps itself?
kind regards

What operating system(s) are you seeing the problem on?

Linux

What browser(s) are you seeing the problem on?

No response

What version of Bootstrap are you using?

5.2

@julien-deramond
Copy link
Member

Thanks for reporting this issue @pine3ree. The example provided with $theme-colors doesn't seem to work. #36535 is a proposal to fix the docs.

@pine3ree
Copy link
Contributor Author

pine3ree commented Jun 9, 2022

@julien-deramond , maybe we should put a comment like // maps customization here!!! in bootstrap.scss between // Configuration and // Layout & components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants