dashboard example: minor fix

[techvanity]

dashboard.css (and rtl version) contain rules for .sidebar-sticky, but these are not being applied currently.

[ffoodd]

Reading .position-sticky on the same elements makes me wonder if the CSS shouldn't be dropped, instead of adding the class name in markup?

Thoughts, @julien-deramond? Might be a leftover from peeviois refactors.

[julien-deramond]

Confirm what's been said by @ffoodd: .sidebar-sticky has been removed in 0ca2cf4 in favor of .position-sticky.
In this PR @techvanity you can drop .sidebar-sticky rules in both dashboard.css/dashboard.rtl.css files rather than using .sidebar-sticky in the markup.

[ffoodd]

I think the RTL file is generated, isn't it?

[julien-deramond]

I think the RTL file is generated, isn't it?

Yep it is possible to modify dashboard.css and then to run npm run css-prefix-examples-rtl to regenerate/modify dashboard.rtl.css.

[techvanity]

Confirm what's been said by @ffoodd: .sidebar-sticky has been removed in 0ca2cf4 in favor of .position-sticky. In this PR @techvanity you can drop .sidebar-sticky rules in both dashboard.css/dashboard.rtl.css files rather than using .sidebar-sticky in the markup.

@julien-deramond and @ffoodd
I beg to differ. Those styles are important, especially setting height and overflow-y so that the sidebar is scrollable when number of items is large. I just tested it - scrolling breaks upon removing that css.

[julien-deramond]

@julien-deramond and @ffoodd I beg to differ. Those styles are important, especially setting height and overflow-y so that the sidebar is scrollable when number of items is large. I just tested it - scrolling breaks upon removing that css.

You're right indeed we can see the issue while reducing the window vertically. So I'd say you can keep your modification (addition of .sidebar-sticky) and remove in both CSS files the unused/useless rules. I haven't tested it but I'm thinking of padding-top already set with .pt, probably position: relative if it becomes useless and some others.
dashboard-rtl/index.html file should be modified as well to use .sidebar-sticky.

[techvanity]

Made the requested changes.
Thanks

[julien-deramond]

LGTM! Thanks @techvanity for this PR!