Add some details for non visible scrollspy elements #36625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
force-pushed
the
gs/docs-add-scrollspy-info
branch
2 times, most recently
from
289f7fb
to
e022aa4
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
GeoSot
force-pushed
the
gs/docs-add-scrollspy-info
branch
from
62cf734
to
6018958
Compare
Please @arcanisgk as your issue, it is out of scope on this PR, try to remove it, and start a new discussion or issue |
julien-deramond
approved these changes
Jul 5, 2022
GeoSot
force-pushed
the
gs/docs-add-scrollspy-info
branch
from
6018958
to
17b4f44
Compare
|
On mobile for now, but how's this read?
|
Committed your proposal to save you some time with the "Co-authored-by" info. |
mdo
approved these changes
Jul 10, 2022
mdo
force-pushed
the
gs/docs-add-scrollspy-info
branch
from
0069f90
to
830e81a
Compare
GeoSot
commented
Jul 11, 2022
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
mdo
force-pushed
the
gs/docs-add-scrollspy-info
branch
from
1118fdd
to
a36872a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #36615
It probably needs proofreading, from a native speaker
Preview : https://deploy-preview-36625--twbs-bootstrap.netlify.app/docs/5.2/components/scrollspy/#how-it-works