Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StackBlitz examples needing docs CSS #36637

Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jun 27, 2022

Reference #36391

Originally I wanted to be able to load only _component-examples.scss and only when needed. The main issue is that it contains Sass variables defined in other Sass files; including files in the framework.

It will be less obvious for the users but the only other way I found so far is to load directly in the index.html our docs.css...

Any other ideas?

Fixed use cases

@julien-deramond julien-deramond added this to In progress in v5.2.0-stable via automation Jun 27, 2022
@julien-deramond julien-deramond marked this pull request as ready for review June 27, 2022 19:10
@julien-deramond julien-deramond force-pushed the main-jd-fix-stackblitz-examples-by-adding-docs-css branch from 3c3803b to 35753db Compare June 27, 2022 19:11
@mdo
Copy link
Member

mdo commented Jun 28, 2022

Loading the docs makes sense to me since that's what we build and publish. Adding a separate stylesheet would be an extra HTTP request. Alternatively we can try to build everything for the snippets with local <style> tags, but that would be messy and repetitive.

Just gives extra motivation to reduce the docs/examples CSS as much as possible.

v5.2.0-stable automation moved this from In progress to Reviewer approved Jun 28, 2022
@julien-deramond julien-deramond merged commit 9cf0e9b into main Jun 28, 2022
v5.2.0-stable automation moved this from Reviewer approved to Done Jun 28, 2022
@julien-deramond julien-deramond deleted the main-jd-fix-stackblitz-examples-by-adding-docs-css branch June 28, 2022 05:31
@julien-deramond julien-deramond mentioned this pull request Jul 19, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants