Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip/badge border radius when rounded disabled #36646

Merged
merged 1 commit into from Jun 29, 2022

Conversation

julien-deramond
Copy link
Member

Following up #36461, same modification should be applied to _badge.scss and _tooltip.scss to retrieve the behavior that was present before the addition of CSS vars for these components.

References - History

How to test

Set locally $enable-rounded: false !default in _variables.css and check corresponding pages in the docs.

@julien-deramond julien-deramond requested a review from a team as a code owner June 29, 2022 20:19
@julien-deramond julien-deramond added this to In progress in v5.2.0-stable via automation Jun 29, 2022
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

v5.2.0-stable automation moved this from In progress to Reviewer approved Jun 29, 2022
@mdo mdo merged commit 9400b8f into main Jun 29, 2022
v5.2.0-stable automation moved this from Reviewer approved to Done Jun 29, 2022
@mdo mdo deleted the main-jd-enable-rounded-false-for-tooltip-and-badge branch June 29, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants