Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: alphabetical reorder of some events/methods in tables #36669

Merged
merged 5 commits into from Jul 6, 2022

Conversation

julien-deramond
Copy link
Member

Minor missing modifications after 8959bf3.

@julien-deramond julien-deramond added this to In progress in v5.2.0-stable via automation Jul 4, 2022
@GeoSot
Copy link
Member

GeoSot commented Jul 4, 2022

I don't know if we want to change the events order, as (most of them) they are written according to the order are triggered

v5.2.0-stable automation moved this from In progress to Reviewer approved Jul 6, 2022
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, but I also wonder if it doesn't make sense to also keep the hide event before hidden for consistency with show/shown. Know it isn't alphabetical, but it logically flows in my mind. Your call though :).

@julien-deramond
Copy link
Member Author

Reverted the change regarding hide/hidden based on both your comments. Let's wait if we have in the future a tool to automatically reorder alphabetically the tables.

@julien-deramond julien-deramond merged commit 22c7503 into main Jul 6, 2022
v5.2.0-stable automation moved this from Reviewer approved to Done Jul 6, 2022
@julien-deramond julien-deramond deleted the main-jd-alphabetical-reorder-of-bs-tables branch July 6, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants