Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--bs-nav-link-font-weight variable missing in .nav class, v5.2.0-beta1. #36684

Closed
3 tasks done
SamuelMiller opened this issue Jul 6, 2022 · 2 comments
Closed
3 tasks done
Labels

Comments

@SamuelMiller
Copy link

Prerequisites

Describe the issue

As shown below, the css variable --bs-nav-link-font-weight is left blank (line 3826), no value/string is given in Bootstrap v5.2.0-beta1, installed via npm.

.nav {
  --bs-nav-link-padding-x: 1rem;
  --bs-nav-link-padding-y: 0.5rem;
  --bs-nav-link-font-weight: ;
  --bs-nav-link-color: var(--bs-link-color);
  --bs-nav-link-hover-color: var(--bs-link-hover-color);
  --bs-nav-link-disabled-color: #6c757d;
  display: flex;
  flex-wrap: wrap;
  padding-left: 0;
  margin-bottom: 0;
  list-style: none;
}

--bs-nav-link-font-weight is used in .nav-link to set font-weight:

.nav-link {
  display: block;
  padding: var(--bs-nav-link-padding-y) var(--bs-nav-link-padding-x);
  font-size: var(--bs-nav-link-font-size);
  font-weight: var(--bs-nav-link-font-weight);
  color: var(--bs-nav-link-color);
  text-decoration: none;
  transition: color 0.15s ease-in-out, background-color 0.15s ease-in-out, border-color 0.15s ease-in-out;
}

Reduced test cases

See above.

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

Chrome

What version of Bootstrap are you using?

v5.2

@julien-deramond
Copy link
Member

julien-deramond commented Jul 6, 2022

Thanks for reporting this issue @SamuelMiller.
IMO it is done on purpose as explained in the description of #31035 (for $nav-link-font-size and $nav-link-font-weight).
It is null by default because not needed in Bootstrap style but can be set by projects by overriding $nav-link-font-weight and/or $nav-link-font-weight.

While checking this issue I may have found an issue but regarding .navbar-nav and proposed #36689
This is not a real duplicate but in the same spirit as #36595

@mdo
Copy link
Member

mdo commented Jul 19, 2022

Closing as duplicate of #36595. Same problem to solve here.

@mdo mdo closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants