Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type="button" to Bootstrap versions dropdown #36696

Merged
merged 1 commit into from Jul 7, 2022
Merged

add type="button" to Bootstrap versions dropdown #36696

merged 1 commit into from Jul 7, 2022

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Jul 7, 2022

minor accessibility issue fix reported by webhint.io browser extension.

image

minor accessibility issue fix reported by webhint.io browser extension
@patrickhlauke
Copy link
Member

ah, good spot. missing type="button" doesn't really have any adverse effect unless you're inside a <form> (as otherwise a button without type="button" automatically acts as a submit button, which may not be intended), but as a good practice, we should definitely have it there either way.

@patrickhlauke patrickhlauke merged commit 6f10bdc into twbs:main Jul 7, 2022
@coliff coliff deleted the patch-3 branch July 7, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants