Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add 'Icons' link in footer #36706

Merged
merged 1 commit into from Jul 9, 2022
Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jul 8, 2022

This PR proposes to add an 'Icons' link in the footer; being the only one missing by comparing to the links in the header.

I was just not sure that it was removed because a design limit to 6 elements max in each footer section.

Live preview

@julien-deramond julien-deramond requested a review from mdo July 8, 2022 11:23
@julien-deramond julien-deramond changed the title Docs: Add 'Icons' link Docs: Add 'Icons' link in footer Jul 8, 2022
@julien-deramond julien-deramond force-pushed the main-jd-add-icons-link-in-footer branch from 046f174 to 0b7eac2 Compare July 8, 2022 11:24
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh damn how'd I miss this haha, thanks!

@mdo mdo merged commit 59a285f into main Jul 9, 2022
@mdo mdo deleted the main-jd-add-icons-link-in-footer branch July 9, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants