Add $display-font-family and $display-font-style
#36711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
force-pushed
the
main-jd-add-display-font-scss-vars
branch
from
0f2d292
to
4b85772
Compare
mdo
force-pushed
the
main-jd-add-display-font-scss-vars
branch
from
4b85772
to
77eaf97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36701
The request from adding
$display-font-familyseemed valid to me in order to have the same customizing possibilities for display and normal headings.By comparing the customization options regarding the font, I'm proposing to add
$display-font-styleas well for more consistency.Live preview
Note: haven't associated this development to any projects yet. Depending if this is judged to be a useful addition for the CSS reviewers and if we have time to review it before v5.2 release.