Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing pagination compile issue #36740

Merged
merged 1 commit into from Jul 18, 2022
Merged

Fixing pagination compile issue #36740

merged 1 commit into from Jul 18, 2022

Conversation

Yohn
Copy link
Contributor

@Yohn Yohn commented Jul 15, 2022

This was an issue with the tables as well, but that has been updated here - 4a3c004

This was also noted here - #1153187062_ and closed to see if others ran into the same issue.

This effects the 5.2 beta1 that is released on the homepage.

Whats happening is with a fresh download and compile, with some compilers, I noticed not all of them run into this issue, we get the Sass variable showing up and not the actual value.

Steps to reproduce -

  • Download the source code form the docs for beta 2 and extract
  • Open VSCode -> open folder to the bootstrap directory you just extracted
  • Install Sass/Less/Stylus/Pug/Jade/Typescript/Javascript Compile Hero Pro v2.3.53 by Eno Yao extension
    ---- Might have to restart VSCode
  • Go to that extensions settings, and set the SASS and SCSS directory to save the output / compiled version to ../dist
  • Tap that Compile Hero on the bottom to activate the extension
  • Open bootstrap.scss add a space or a new line and save it
  • Check the compiles version and you should see the errors

@Yohn Yohn requested a review from a team as a code owner July 15, 2022 04:15
@mdo mdo added this to In progress in v5.2.0-stable via automation Jul 18, 2022
@mdo
Copy link
Member

mdo commented Jul 18, 2022

Yeah we can ship this and solve this problem, too. Thanks for opening!

This was an issue with the tables as well, but that has been updated here - 4a3c004

This was also noted here - 36501#issuecomment-1153187062_

This effects the 5.2 beta1 that is released on the homepage.

Whats happening is with a fresh download and compile, with some compilers, I noticed not all of them run into this issue, we get the Sass variable showing up and not the actual value.

Steps to reproduce - 
 - Download the source code form the docs for beta 2 and extract
 - Open VSCode -> open folder to the bootstrap directory you just extracted
 - install the "Sass/Less/Stylus/Pug/Jade/Typescript/Javascript Compile Hero Pro" v2.3.53 by Eno Yao extension
 ---- might have to restart VSCode
 - go to that extensions settings, and set the directory to save the output / compiled version to `../dist`
 - tap that Compile Hero on the bottom to activate the extension
 - open `bootstrap.scss` add a space or a new line and save it
 - check the compiles version and you should see the errors
@mdo mdo merged commit 154916c into twbs:main Jul 18, 2022
v5.2.0-stable automation moved this from In progress to Done Jul 18, 2022
@julien-deramond
Copy link
Member

julien-deramond commented Jul 19, 2022

@Yohn Just for information, don't you have an issue with the following line as well?

@if $pagination-margin-start == (calc($pagination-border-width * -1)) {

@Yohn
Copy link
Contributor Author

Yohn commented Jul 19, 2022

@julien-deramond I didn't have that line alert me the other day when I was compiling, but it does look like it could.
I'll re-compile the master branch the same way again when I get home and will let you know. Give me a couple hours.

@Yohn
Copy link
Contributor Author

Yohn commented Jul 20, 2022

@Yohn Just for information, don't you have an issue with the following line as well?

@if $pagination-margin-start == (calc($pagination-border-width * -1)) {

@julien-deramond I was able to compile the scss without any issues with both the beta and now the current 5.2 branches.
Good looking out!

@julien-deramond
Copy link
Member

Thanks a lot @Yohn for that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants