Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btn-link no longer has an outline when clicked #36744

Closed
3 tasks done
imaperson1060 opened this issue Jul 15, 2022 · 3 comments · Fixed by #36747
Closed
3 tasks done

btn-link no longer has an outline when clicked #36744

imaperson1060 opened this issue Jul 15, 2022 · 3 comments · Fixed by #36747

Comments

@imaperson1060
Copy link

imaperson1060 commented Jul 15, 2022

Prerequisites

Describe the issue

When using .btn-link in v5.2.0 Beta 1, the button looks like a normal link instead of having the blue button outline when clicked (this worked in v5.1.3).

Reduced test cases

<button class="btn btn-sm btn-link">Text</button>

What operating system(s) are you seeing the problem on?

Windows, Android

What browser(s) are you seeing the problem on?

Chrome

What version of Bootstrap are you using?

5.2.0

@julien-deramond
Copy link
Member

julien-deramond commented Jul 16, 2022

Thanks for reporting this issue @imaperson1060. Confirm this regression that happened with ef9d853.
It has been partially fixed recently since we can see the outline in https://twbs-bootstrap.netlify.app/docs/5.2/components/buttons/ (deployment of the current main branch).

However:

  • when active, the text is black and should be dark blue.
  • when focused, the text is dark blue and should be blue.

@julien-deramond julien-deramond added this to To do in v5.2.0-stable via automation Jul 16, 2022
@julien-deramond julien-deramond moved this from To do to In progress in v5.2.0-stable Jul 16, 2022
v5.2.0-stable automation moved this from In progress to Done Jul 18, 2022
@imaperson1060
Copy link
Author

Sooooo 5.2.1 kinda broke this again lol.
If it helps here's the only difference I found in inspect elements:
5.2.1:
image
5.2.0 (stable):
image
Sorry for bothering you again!😅

@julien-deramond
Copy link
Member

@imaperson1060 In v5.2.1, in #37026, this behavior has been voluntarily changed:

for all .btns, it changes the :focus styling to :focus-visible - this way, the focus style doesn't take effect and "stick" (until you click somewhere else) for mouse/touch users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants