Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix active/focused button link text color #36747

Merged
merged 1 commit into from Jul 18, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jul 16, 2022

Fixes #36744 (see #36744 (comment))

This PR proposes some changed for .btn-links to retrieve the same behavior from 5.1 regarding focus, active, hover and all combinations between those states.

Live preview

/CC @mdo - IMHO a fix for this one should be embedded if possible in the v5.2.0

@julien-deramond julien-deramond force-pushed the main-jd-fix-active-focused-text-color-of-btn-link branch 3 times, most recently from 3b5a8dc to af6b393 Compare July 16, 2022 09:56
@julien-deramond julien-deramond marked this pull request as ready for review July 16, 2022 09:59
@julien-deramond julien-deramond requested a review from a team as a code owner July 16, 2022 09:59
@mdo mdo added this to In progress in v5.2.0-stable via automation Jul 18, 2022
v5.2.0-stable automation moved this from In progress to Reviewer approved Jul 18, 2022
@mdo mdo force-pushed the main-jd-fix-active-focused-text-color-of-btn-link branch from af6b393 to 9544bb7 Compare July 18, 2022 03:43
@mdo mdo merged commit 150b374 into main Jul 18, 2022
v5.2.0-stable automation moved this from Reviewer approved to Done Jul 18, 2022
@mdo mdo deleted the main-jd-fix-active-focused-text-color-of-btn-link branch July 18, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

btn-link no longer has an outline when clicked
2 participants