Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScrollSpy: make the threshold option configurable #36750

Merged
merged 5 commits into from Jul 28, 2022
Merged

ScrollSpy: make the threshold option configurable #36750

merged 5 commits into from Jul 28, 2022

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Jul 16, 2022 •
edited

ref #36431

@GeoSot GeoSot requested a review from a team as a code owner July 16, 2022 11:54
@GeoSot GeoSot added this to In progress in v5.2.0-stable via automation Jul 16, 2022
@GeoSot GeoSot mentioned this pull request Jul 16, 2022
Open
@GeoSot GeoSot added the feature label Jul 16, 2022
@GeoSot GeoSot force-pushed the gs/add-scrollspy-threshold-options branch from 85cec49 to b5daa3f Compare July 18, 2022 12:24
@GeoSot GeoSot moved this from In progress to Review in progress in v5.2.0-stable Jul 18, 2022
@GeoSot GeoSot force-pushed the gs/add-scrollspy-threshold-options branch from 5fa2f60 to 3896c84 Compare July 18, 2022 19:52
@mdo mdo removed this from Review in progress in v5.2.0-stable Jul 19, 2022
@GeoSot GeoSot force-pushed the gs/add-scrollspy-threshold-options branch 3 times, most recently from 4abaaed to b462723 Compare July 26, 2022 14:50
julien-deramond
julien-deramond requested changes Jul 27, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested how it works in details but the mechanism to provide the threshold param seems to work pretty well.
Just few proposals of improvement and a question on my side.

site/content/docs/5.2/components/scrollspy.md Outdated Show resolved Hide resolved
js/tests/unit/scrollspy.spec.js Show resolved Hide resolved
js/tests/unit/scrollspy.spec.js Outdated Show resolved Hide resolved
js/src/scrollspy.js Show resolved Hide resolved
@GeoSot GeoSot force-pushed the gs/add-scrollspy-threshold-options branch from 992c2ec to 5fd45ba Compare July 27, 2022 13:22
julien-deramond
julien-deramond approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Don't know if anyone want to double check this one.

@GeoSot GeoSot force-pushed the gs/add-scrollspy-threshold-options branch from 5fd45ba to 23ddc61 Compare July 27, 2022 14:40
GeoSot and others added 5 commits July 28, 2022 11:14
@GeoSot
feat(ScrollSpy): make the threshold option configurable
526256f
@GeoSot
add tests and support markup
56b6818
@GeoSot @julien-deramond
Update js/tests/unit/scrollspy.spec.js
b562213 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
@GeoSot @julien-deramond
Update js/tests/unit/scrollspy.spec.js
ed01323 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
@GeoSot @julien-deramond
Update site/content/docs/5.2/components/scrollspy.md
6e8ba11 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
@GeoSot GeoSot force-pushed the gs/add-scrollspy-threshold-options branch from 23ddc61 to 6e8ba11 Compare July 28, 2022 08:15
@GeoSot GeoSot merged commit db86607 into main Jul 28, 2022
@GeoSot GeoSot deleted the gs/add-scrollspy-threshold-options branch July 28, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
feature js v5
Projects
No open projects
v5.2.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GeoSot @julien-deramond