Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-set tooltip title on disposal #36751

Merged
merged 3 commits into from Jul 27, 2022
Merged

Re-set tooltip title on disposal #36751

merged 3 commits into from Jul 27, 2022

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Jul 16, 2022

closes #36743

@GeoSot GeoSot requested a review from a team as a code owner July 16, 2022 14:34
@GeoSot GeoSot added this to In progress in v5.2.0-stable via automation Jul 16, 2022
@GeoSot GeoSot moved this from In progress to Review in progress in v5.2.0-stable Jul 18, 2022
@mdo mdo removed this from Review in progress in v5.2.0-stable Jul 19, 2022
@GeoSot GeoSot force-pushed the gs/regression-reset-tooltip-title branch 2 times, most recently from 34f0594 to 3fca31b Compare July 22, 2022 09:32
@mdo
Copy link
Member

mdo commented Jul 25, 2022

Once we get a review on this, we can merge it and discuss ship date for v5.2.1.

@GeoSot GeoSot force-pushed the gs/regression-reset-tooltip-title branch from 3fca31b to 746373f Compare July 26, 2022 14:45
julien-deramond
julien-deramond approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug is fixed. Played a bit with it, LGTM!
Just a typo comment that doesn't need my review.

js/tests/unit/tooltip.spec.js Outdated Show resolved Hide resolved
@GeoSot GeoSot merged commit dfae892 into main Jul 27, 2022
@GeoSot GeoSot deleted the gs/regression-reset-tooltip-title branch July 27, 2022 14:40
@GeoSot GeoSot mentioned this pull request Aug 4, 2022
Closed
3 tasks
@XhmikosR XhmikosR changed the title Re-set tooltip title, on disposal Re-set tooltip title on disposal Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
affects-main-branch js v5
Projects
No open projects
v5.2.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5.2.0 Regression when recreating disposed tooltips using title
3 participants
@GeoSot @mdo @julien-deramond