Fix event handler test #36772
Merged
Fix event handler test #36772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
LGTM!
Here are the tests that I've done:
- Revert the changes in
event-handler.jsto check if the test fails. It fails so it's good. - Add some logs in the
catchpart inevent-handler.jsto check if the test still goes in that part of the code. It does so it's good. - Ubuntu + Chrome: test passes (no regression)
- Ubuntu + Firefox: test passes (no regression)
- Mac + Chrome: test passes (no regression)
- Mac + Firefox: test passes 🎉
BrowserStack is 🟢 (sometimes) so the bug seems fixed. GG @GeoSot
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #36749