Simplify social images and add ability to set per-page images #36804
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
force-pushed
the
custom-social-images
branch
from
717db5b
to
ff470ce
Compare
julien-deramond
approved these changes
Jul 21, 2022
mdo
force-pushed
the
custom-social-images
branch
from
ff470ce
to
e75dc7b
Compare
|
@julien-deramond Implemented your suggested changes and cleaned up a couple things. Thanks! |
- Removes the homepage summary layout in favor of the larger image card (makes it more consistent with other pages) - Reuses new thumbnails for Webpack, Parcel, and Vite guides to add their new social images
mdo
force-pushed
the
custom-social-images
branch
from
e75dc7b
to
f7b9fbf
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing a few things after v5.2.0 went stable:
Possibly more custom cards to come, but might push that to separate PRs. Ideas welcome on this :).