Move DocSearch out of offcanvas to always show it on mobile #36824
Conversation
|
Note: if merged, can close #36822 |
|
Issues should be smoothed out now. |
|
Related question to the behavior here... should we switch the positions of our offcanvas toggles? Does it make sense to have the global nav on the right, and the sidebar on the left? |
There was a problem hiding this comment.
LGTM with the latest changes!
Related question to the behavior here... should we switch the positions of our offcanvas toggles? Does it make sense to have the global nav on the right, and the sidebar on the left?
I more used to have the global nav on the right so having the sidebar on the left doesn't shock me. I find it more disturbing at first to have the three dots (...) for the global nav and the burger menu for the secondary menu/sidebar, than their left/right position.
|
Rad, that's good to hear. Regarding icons, I'm open to hearing new icon suggestions :). I'll think on it as well. |
Easier fix than continuing to mess with offcanvas options or consider building on top of DocSearch itself. This moves the partial out of the navbar offcanvas so that it can be always visible on mobile. I've added some additional styles to make the mobile state better match our navbar iconography as well.
/cc @julien-deramond @GeoSot
Fixes #36822.