Fix pagination page items border radius #36828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After I compiled the changes you pointed out the other week, I did fail to look at the pagination component to see how it rendered. I should have done that. I was just checking to see if it would compile without throwing any error. Good catch and quick fix. I'll keep in mind moving forward to make sure I inspect each component modified - and to get the contributing post template. |
mdo
approved these changes
Jul 25, 2022
mdo
force-pushed
the
main-jd-fix-pagination-border-radius
branch
from
44a5802
to
08586a4
Compare
|
Will this be backported to 5.2.0, since it's a bug and a breaking change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify
@if $pagination-margin-start == (calc($pagination-border-width * -1)) {to work like the recent fix done in 154916c.Motivation & Context
In some Sass compilers
($pagination-border-width * -1) == (calc($pagination-border-width * -1))is evaluated tofalseand some users, like the issue's author, can see an unexpected border radius for.page-items in a pagination.Types of changes
Checklist
npm run lint)My change introduces changes to the documentationI have updated the documentation accordinglyI have added tests to cover my changesRelated issues
Fixes #36820
Live preview