Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Missing added-in shortcode #36838

Merged
merged 3 commits into from Jul 25, 2022

Conversation

louismaximepiton
Copy link
Member

The commits can be splited if needed

@louismaximepiton louismaximepiton changed the title Missing added in shortcode Docs: Missing added-in shortcode Jul 25, 2022
@coliff
Copy link
Contributor

coliff commented Jul 25, 2022

looks like the Offcanvas one is fixed in 36836

@louismaximepiton
Copy link
Member Author

I might be wrong but I think it is slightly different since it is an addition for .dark-offcanvases here.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @mdo I let you double check to see if it is compliant with the global use of those tags in the documentation.

@julien-deramond julien-deramond requested a review from mdo July 25, 2022 19:33
@mdo mdo merged commit dc901d2 into twbs:main Jul 25, 2022
@louismaximepiton louismaximepiton deleted the main-lmp-missing-added-in branch September 2, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants