Fix modal event-listeners during dismiss click #36863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folknor
reviewed
Aug 5, 2022
GeoSot
force-pushed
the
gs-fix-modal-scrollbar-click
branch
from
bdb569b
to
d6c2aab
Compare
GeoSot
force-pushed
the
gs-fix-modal-scrollbar-click
branch
from
9300215
to
a41d71f
Compare
mdo
force-pushed
the
gs-fix-modal-scrollbar-click
branch
from
a41d71f
to
d710920
Compare
|
Is this good to merge @GeoSot or do you need a review from someone? |
|
I would appreciate a review just to be sure |
julien-deramond
approved these changes
Sep 7, 2022
GeoSot
force-pushed
the
gs-fix-modal-scrollbar-click
branch
from
d710920
to
cf6b611
Compare
GeoSot
force-pushed
the
gs-fix-modal-scrollbar-click
branch
from
cf6b611
to
3d0c07b
Compare
ghost
mentioned this pull request
|
@GeoSot Any 5.2.2 release ? Can you disable 5.2.1 because it broke many projets. Have to force 5.2.0 for now. |
Yes, please do a 5.2.2 soon. Thank you! |
|
I can understand you on this. I personally, have done a lot of refactoring to bring our codebase to a better condition, preparing it for v6, and unfortunately sometimes mistakes can be done. I apologize for this. |
|
I will release 5.2.2 tomorrow or Monday. Please be patient.
…On Sat, Oct 1, 2022, 19:58 GeoSot ***@***.***> wrote:
I can understand you on this. I personally, have done a lot of refactoring
to bring our codebase to a better condition, preparing it for v6, and
unfortunately sometimes mistakes can be done. I apologize for this.
Furthermore, as a team, we are trying our best, working on our free time,
so please make some patience and we will try to have a release soon
—
Reply to this email directly, view it on GitHub
<#36863 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNOTTBSVQK2ZRGD3XRDWBBUUNANCNFSM55CIOTHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially regression of #36401.
Fixes modal listeners in order to:
mousedown,mouseuplisten to scrollbar clickclickignores scrollbar click.modal-dialog, but ends outside of it.modal-dialogcloses: #36855
alternative approach #36855 (comment)