Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion color should use $accordion-color #36921

Merged
merged 1 commit into from Sep 1, 2022
Merged

Conversation

giovannipiller
Copy link
Contributor

This makes it possible to easily override the color without breaking the SASS compilation.

e.g. color-contrast(...) requires a valid color. There are scenarios where it's interesting to pass a CSS variable, which can't be computed by color-contrast.
For example, $accordion-bg: var(--my-accordion-bg) currently breaks the build.

Besides, $accordion-color already exists, so it makes sense to use it.

@giovannipiller
Copy link
Contributor Author

I'm in no rush, but is there anything that I can double-check to expedite this review?

@mdo
Copy link
Member

mdo commented Sep 1, 2022

Sorry for the delay, getting it merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants