Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix js options to what is really inside js #37019

Merged
merged 3 commits into from Aug 31, 2022

Conversation

louismaximepiton
Copy link
Member

Fixes #36936.

@GeoSot
Copy link
Member

GeoSot commented Aug 31, 2022

Plus, you may include #36936 too

@louismaximepiton louismaximepiton requested a review from a team as a code owner August 31, 2022 10:18
@louismaximepiton
Copy link
Member Author

Plus, you may include #36936 too

I think this is already taken into account in https://github.com/twbs/bootstrap/pull/37019/files#diff-eea88f447d7813cdc4b41d8d41bfd86111df371dc511a094bf8af223fe07cb00R149. Am I wrong ?

@GeoSot
Copy link
Member

GeoSot commented Aug 31, 2022

Sorry, my mistake

@GeoSot GeoSot force-pushed the main-lmp-doc-js-options-fix branch from cede05e to b260c3a Compare August 31, 2022 13:47
@GeoSot GeoSot merged commit 29332a9 into twbs:main Aug 31, 2022
@louismaximepiton louismaximepiton deleted the main-lmp-doc-js-options-fix branch September 2, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Collapse.Options.parent default value: Type 'boolean' is not assignable to type 'string | Element | JQuery'
3 participants