More consistency for CSS/Sass vars doc for components with dark variants #37034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
force-pushed
the
main-jd-improve-docs-for-css-scss-variables-for-dark-variants
branch
from
9c37686
to
571d6f6
Compare
mdo
deleted the
main-jd-improve-docs-for-css-scss-variables-for-dark-variants
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a proposal to bring consistency between dropdowns, carousels and navbars docs which have all a dark variant.
Motivation & Context
This PR is a proposal to bring consistency between dropdowns, carousels and navbars docs which have all a dark variant.
Dropdowns documentation is taken as a reference being more detailed:
Customization through CSS variables can be seen on the .dropdown-menu-dark class where we override specific values without adding duplicate CSS selectors.Types of changes
Checklist
npm run lint)I have added tests to cover my changesRelated issues
N/A
Live previews