Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: improve cards image overlays markup #37048

Merged
merged 2 commits into from Sep 1, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Aug 29, 2022

All cards examples have the same structure regarding the content:

  <div class="card-body">
    <h5 class="card-title">Card title</h5>
    <p class="card-text">This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer.</p>
    <p class="card-text"><small class="text-muted">Last updated 3 mins ago</small></p>
  </div>

The one in Image overlays doesn't contain the <small class="text-muted">...</small>.
Since .text-muted makes it non-accessible, I chose to only add the <small> HTML element.

Live preview

@MadhavanBS

This comment was marked as duplicate.

@mdo mdo merged commit 465cc2d into main Sep 1, 2022
@mdo mdo deleted the main-jd-improve-some-cards-examples branch September 1, 2022 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants