Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docs clearer by dropping precompiled for compiled #37067

Merged
merged 1 commit into from Sep 1, 2022
Merged

Conversation

mdo
Copy link
Member

@mdo mdo commented Sep 1, 2022

Replaces #36861. This PR just aims to clarify some language without keeping the precompiled word around. The usage in that PR is more confusing and sometimes wrong IMO. Here I just changed it all to compiled, nested the headings for a more logical doc structure, and fixed a few other little issues.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdo mdo merged commit 2793637 into main Sep 1, 2022
@mdo mdo deleted the rm-precompiled branch September 1, 2022 19:16
@3-2
Copy link

3-2 commented Sep 2, 2022

Replaces #36861. This PR just aims to clarify some language without keeping the precompiled word around. The usage in that PR is more confusing and sometimes wrong IMO. Here I just changed it all to compiled, nested the headings for a more logical doc structure, and fixed a few other little issues.

Thank you for your work! I am the one who submitted the issue #36861.

I haven't used and don't understand much of Bootstrap. In fact, I just started to read its documentation.

Now I realized that I am wrong.

@mdo
Copy link
Member Author

mdo commented Sep 2, 2022

All good! Thanks for reporting regardless :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants