Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since 5.2.1 modals closes on content removal #37126

Closed
3 tasks done
ghost opened this issue Sep 12, 2022 · 3 comments · Fixed by #37128
Closed
3 tasks done

Since 5.2.1 modals closes on content removal #37126

ghost opened this issue Sep 12, 2022 · 3 comments · Fixed by #37128
Labels

Comments

@ghost
Copy link

ghost commented Sep 12, 2022

Prerequisites

Describe the issue

Since version 5.2.1, when a button in the modal body triggers the removal of the button itself or its parent, the modal closes. It worked correctly with version 5.2.0.

Edit:

Definitely related to #36863, reverting it fixes the issue.

Reduced test cases

For both test cases, click on the "Open modal" button then click on any "Remove row" button.

What operating system(s) are you seeing the problem on?

Linux

What browser(s) are you seeing the problem on?

Firefox

What version of Bootstrap are you using?

5.2.1

@joelstein
Copy link

Bootstrap 5.2.1's modal change introduced in #36863 is causing problems for me, too, as described in this issue.

In modals, I have buttons and dropdowns hidden after a click. With Bootstrap 5.2.1, the modal dismisses after clicking these things, which is naturally surprising to our users.

The fix in #37128 resolves the issue for us.

GeoSot added a commit that referenced this issue Sep 15, 2022
* Fix modal event listeners (#37126)

Co-authored-by: GeoSot <geo.sotis@gmail.com>
@joelstein
Copy link

Thanks for fixing and merging this!

@neoteknic
Copy link

release a 5.2.2 ? Or remove 5.2.1 because it broke many projets with modal boxes. Force 5.2.0 in package.json to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants