Skip to content

Drop tabs auto-focus #37146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2022
Merged

Drop tabs auto-focus #37146

merged 2 commits into from
Sep 20, 2022
+29 −3

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Sep 14, 2022

closes #37107

@GeoSot GeoSot requested a review from a team as a code owner September 14, 2022 09:54
@GeoSot GeoSot force-pushed the gs/drop-tab-autofocus branch from b875991 to 3fb0153 Compare September 15, 2022 19:33
mdo
mdo approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since referenced issue had fix confirmed.

@GeoSot
fix: drop tabs auto-focus
da97f97
@GeoSot
add tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
73b0995
@GeoSot GeoSot force-pushed the gs/drop-tab-autofocus branch from 3fb0153 to 73b0995 Compare September 20, 2022 14:18
@GeoSot GeoSot merged commit 1510c25 into main Sep 20, 2022
@GeoSot GeoSot deleted the gs/drop-tab-autofocus branch September 20, 2022 14:20
XhmikosR pushed a commit that referenced this pull request Oct 2, 2022
@GeoSot @julien-deramond
Ensure Tab keyboard functionality after #37146 (#37200)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d49d8ce 
* fix: keyboard functionality

* test: add tests

* Add some focus spies in 2 other unit tests

Co-authored-by: Julien Déramond <juderamond@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo

Assignees
No one assigned
Labels
js v5
Projects
No open projects
v5.2.2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5.2.x tab.show() makes the page scroll to tab
2 participants
@GeoSot @mdo