Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box shadows have disappeared from the active state of buttons #37327

Closed
3 tasks done
fabiochelly opened this issue Oct 16, 2022 · 6 comments
Closed
3 tasks done

Box shadows have disappeared from the active state of buttons #37327

fabiochelly opened this issue Oct 16, 2022 · 6 comments

Comments

@fabiochelly
Copy link

Prerequisites

Describe the issue

Since version 5.2, all box-shadows have disappeared from the active state of buttons. Is it a bug?
If not, is there a way to get them back? This focus rect was one of the things that make Bootstrap buttons beautiful.

Reduced test cases

Just install Bootstrap 5.2. Buttons No box-shadow anymore on the active state of buttons

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome, Firefox

What version of Bootstrap are you using?

5.2.0

@julien-deramond
Copy link
Member

Thanks for opening this issue @fabiochelly.
The active state hasn't changed between v5.1 and v5.2; there's no box-shadow for the active state but rather a darker color.
Maybe you're talking about the focus state which has changed. For all .btns, the :focus styling has changed to :focus-visible - this way, the focus style doesn't take effect and "stick" (until you click somewhere else) for mouse/touch users.

@julien-deramond julien-deramond changed the title Provide a general summary of the issue Box shadows have disappeared from the active state of buttons Oct 16, 2022
@fabiochelly
Copy link
Author

fabiochelly commented Oct 16, 2022

Yes, I was effectively referring to the focus state. It's just my advice but is was far more beautiful before this change (I also preferred the less round corners).
Is there a way to go back to the previous focus mode (even by adding some custom CSS to the btn class)? In addition to being prettier, it was very useful to see which button was clicked last.

@mdo
Copy link
Member

mdo commented Oct 31, 2022

Going to close for now as we'd like this change to stick around. Let's wait on getting some more feedback here and decide what to do after that. Thanks!

@mdo mdo closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2022
@vinibiavatti1
Copy link

vinibiavatti1 commented Nov 9, 2022

So, is there some documentation explaining the reason about this change? I noticed now too, and wanted just to know why this features was removed for the buttons. I tryed to find something in the blog but could not find anything.

@julien-deramond
Copy link
Member

So, is there some documentation explaining the reason about this change? I noticed now too, and wanted just to know why this features was removed for the buttons. I tryed to find something in the blog but could not find anything.

You'll probably find more information in #37026 and maybe in the corresponding closed issues as well.

@vinibiavatti1
Copy link

Thanks @julien-deramond

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants