Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import root so that utilities have the CSS variables they need #37377

Merged
merged 4 commits into from Oct 29, 2022
Merged

Import root so that utilities have the CSS variables they need #37377

merged 4 commits into from Oct 29, 2022

Conversation

ericleib
Copy link
Contributor

Description

Import root so that utilities have the CSS variables they need

Motivation & Context

This fixes #37376 (bootstrap-utilities.css missing required CSS variables)

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@ericleib ericleib requested a review from a team as a code owner October 25, 2022 10:13
mdo
mdo approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks! Not sure how we missed that earlier hah.

julien-deramond
julien-deramond approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @ericleib

@julien-deramond julien-deramond merged commit 60b0204 into twbs:main Oct 29, 2022
julien-deramond pushed a commit that referenced this pull request Nov 19, 2022
@ericleib @julien-deramond
Import root in bootstrap-utilities (#37377)
3518b73 
* Fixes #37376
XhmikosR pushed a commit that referenced this pull request Nov 21, 2022
@ericleib @XhmikosR
Import root in bootstrap-utilities (#37377)
77c456d 
* Fixes #37376
@ctipper ctipper mentioned this pull request Dec 15, 2022
Closed
@damian-snyk damian-snyk mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
css v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bootstrap-utilities.css missing CSS variables
3 participants
@ericleib @mdo @julien-deramond