Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 5.2 with dart-sass v1.56.0 #37465

Closed
3 tasks done
Maaaleeek opened this issue Nov 9, 2022 · 3 comments
Closed
3 tasks done

Bootstrap 5.2 with dart-sass v1.56.0 #37465

Maaaleeek opened this issue Nov 9, 2022 · 3 comments

Comments

@Maaaleeek
Copy link

Prerequisites

Describe the issue

After I update dart-sass from v1.55.0 to v1.56.0 link using Bootstrap v5.2.2, I get multiples warnings after npm run build like:

SassWarning: Deprecation $weight: Passing a number without unit % (100) is deprecated
To preserve current behavior: $weight * 1%

More information: https://sass-lang.com/d/function-units

nodes_modules/bootstrap/scss/_functions.scss 201:11      opaque()
nodes_modules/bootstrap/scss/_functions.scss 175:18      contrast-ratio()
nodes_modules/bootstrap/scss/_functions.scss 159:22      color-contrast()
nodes_modules/bootstrap/mixins/_forms.scss 22:19         form-validation-state()
nodes_modules/bootstrap/forms/_validation.scss 9:9       @import
nodes_modules/bootstrap/_forms.scss 9:9                  @import

Reduced test cases

package.json

"bootstrap": "^5.2.2",
"sass": "^1.56.0",
"sass-loader": "^13.1.0",
"webpack": "^5.74.0",
"webpack-cli": "^4.10.0",

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

No response

What version of Bootstrap are you using?

v5.2.2

@julien-deramond
Copy link
Member

Closing it. Duplicate of #37424 already fixed.

@julien-deramond julien-deramond closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2022
@dakur
Copy link

dakur commented Nov 11, 2022

@julien-deramond Hi, I know you wrote in #37424 that this will be released in 5.3.0. But couldn't it be released as a patch earlier? Please see my question in #37467. Thanks for consideration.

@julien-deramond
Copy link
Member

Hey @dakur. We are discussing it in the core team, I'll provide an answer in #37467 as soon as we have decided something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants