Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Home and End keys in tabs #38498

Merged
merged 11 commits into from Jul 23, 2023
Merged

Support Home and End keys in tabs #38498

merged 11 commits into from Jul 23, 2023

Conversation

kyletsang
Copy link
Contributor

@kyletsang kyletsang commented Apr 23, 2023 •
edited

Description

Adds support for Home and End keys in JS tabs.

Motivation & Context

Better tab accessibility support

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #38471

@kyletsang kyletsang requested a review from a team as a code owner April 23, 2023 04:46
@kyletsang kyletsang marked this pull request as draft April 23, 2023 04:53
@XhmikosR XhmikosR removed the request for review from a team April 23, 2023 05:27
@kyletsang kyletsang marked this pull request as ready for review April 23, 2023 05:29
@GeoSot
Copy link
Member

GeoSot commented Apr 29, 2023

@patrickhlauke is it a navigation behavior we should support or not?

@patrickhlauke
Copy link
Member

@GeoSot it's not essential, but a nice-to-have https://www.w3.org/WAI/ARIA/apg/patterns/tabs/#keyboardinteraction

@mdo
Copy link
Member

mdo commented Jun 1, 2023

@GeoSot @XhmikosR Is this good to go?

@GeoSot GeoSot self-requested a review June 1, 2023 15:58
@GeoSot
Copy link
Member

GeoSot commented Jun 8, 2023

Seems fine to me 👍

@XhmikosR XhmikosR merged commit d45cc7e into twbs:main Jul 23, 2023
15 checks passed
@kyletsang kyletsang deleted the tab-home-end-key branch July 24, 2023 05:10
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@kyletsang @patrickhlauke
@XhmikosR @mdo @romankupchak93
Support Home and End keys in tabs (twbs#38498)
6c423c7 
* Support `Home` and `End` keys in tabs

* Update tab.js

* simplify tests

* Update navs-tabs.md

* Update .bundlewatch.config.json

---------

Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhlauke patrickhlauke patrickhlauke left review comments

@mdo mdo mdo approved these changes

@GeoSot GeoSot GeoSot approved these changes

Assignees
No one assigned
Labels
accessibility js v5
Projects
No open projects
v5.3.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve tab navigations accessibility with Home and End keys
6 participants
@kyletsang @GeoSot @patrickhlauke @mdo @XhmikosR @julien-deramond