Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate $alert Sass variables #38672

Closed
3 tasks done
endcoreAK opened this issue May 30, 2023 · 1 comment · Fixed by #38674
Closed
3 tasks done

Duplicate $alert Sass variables #38672

endcoreAK opened this issue May 30, 2023 · 1 comment · Fixed by #38674

Comments

@endcoreAK
Copy link

Prerequisites

Describe the issue

Even if the color scale will be removed with v6 these variables are currently duplicated into variables.scss. Was this forgotten, or is there a reason regarding the documentation?

$alert-bg-scale:                -80% !default;
$alert-border-scale:            -70% !default;
$alert-color-scale:             40% !default;

$alert-bg-scale:                -80% !default; // Deprecated in v5.2.0, to be removed in v6
$alert-border-scale:            -70% !default; // Deprecated in v5.2.0, to be removed in v6
$alert-color-scale:             40% !default; // Deprecated in v5.2.0, to be removed in v6

Reduced test cases

https://github.com/twbs/bootstrap/blob/main/scss/_variables.scss#L1546-L1555

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

No response

What version of Bootstrap are you using?

5.3.0-alpha3

@julien-deramond julien-deramond changed the title Provide a general summary of the issue Duplicate $alert Sass variables May 30, 2023
@julien-deramond
Copy link
Member

Good catch @endcoreAK! It's handled in #38674.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants