Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add $navbar-dark-icon-color #38673

Merged
merged 1 commit into from Jun 1, 2023
Merged

Add $navbar-dark-icon-color #38673

merged 1 commit into from Jun 1, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented May 30, 2023 •
edited

Description

This PR adds a new Sass var named $navbar-dark-icon-color mirroring the behavior of $navbar-light-icon-color.

IMO it can wait for v5.3.x

Motivation & Context

Consistency in Bootstrap usage between light and dark.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (N/A) My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #38671

@julien-deramond julien-deramond marked this pull request as ready for review May 30, 2023 14:34
@julien-deramond julien-deramond requested a review from a team as a code owner May 30, 2023 14:34
louismaximepiton
louismaximepiton approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great and doesn't weight up the bundle 👍

@julien-deramond julien-deramond mentioned this pull request May 30, 2023
Closed
3 tasks
@mdo mdo merged commit ad724cb into main Jun 1, 2023
15 checks passed
@mdo mdo deleted the main-jd-add-navbar-dark-icon-color branch June 1, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
color mode css v5
Projects
No open projects
v5.3.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$navbar-dark-icon-color missing?
3 participants
@julien-deramond @mdo @louismaximepiton