Update bottom border on dark navbar example #38707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
julien-deramond
changed the title
julien-deramond
force-pushed
the
main-jd-drop-border-bottom-from-navbar-color-schemes
branch
from
7434d8e
to
9c15cee
Compare
|
Based on #38706 (comment), reintroduced the bottom border associated to |
mdo
approved these changes
Jun 25, 2023
mdo
changed the title
romankupchak93
pushed a commit
to romankupchak93/bootstrap
that referenced
this pull request
Jan 5, 2024
* Docs: drop bottom border from dark navbar example * Use `.border-body`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #38706,
.border-bottom-darkdoesn't exist in Bootstrap.Moreover, adding a border is finally probably a bit useless here since it adds some noise to the understanding of the concept explained in this section. Rather than fixing it, IMO, it's better to completely remove the border and focus only on the color scheme concept.
However, if you have a strong opinion on its presence and that it's still useful to see the limit of the navbar in dark mode, we could use in this case
.border-bodyinstead of.border-dark.Motivation & Context
A better understanding of the feature without noise.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #38706