Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack examples #38745

Merged
merged 1 commit into from Jun 13, 2023
Merged

Fix stack examples #38745

merged 1 commit into from Jun 13, 2023

Conversation

kyletsang
Copy link
Contributor

@kyletsang kyletsang commented Jun 12, 2023

Description

I was going over the stack docs and noticed that the first two horizontal stack examples were the same. I think the .ms-auto class was accidentally removed in https://github.com/twbs/bootstrap/pull/37900/files

Motivation & Context

Fixes examples so it matches wording.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the fix @kyletsang

@XhmikosR XhmikosR merged commit d8883d7 into twbs:main Jun 13, 2023
15 checks passed
@kyletsang kyletsang deleted the fix-stack-examples branch June 13, 2023 21:05
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants