Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.text-bg-* helpers now use theme CSS variables #38772

Merged
merged 3 commits into from Jul 17, 2023
Merged

.text-bg-* helpers now use theme CSS variables #38772

merged 3 commits into from Jul 17, 2023

Conversation

cameronhollis
Copy link
Contributor

@cameronhollis cameronhollis commented Jun 14, 2023 •
edited by mdo

Description

Changed .text-bg-primary, .text-bg-secondary, etc to use their respective --bs-___-rgb variables instead of hard coded values.

Motivation & Context

This change solves the problem brought up in Issue #38769: text-bg-primary does not respect --bs-primary color.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Fixes #38769

@cameronhollis cameronhollis requested a review from a team as a code owner June 14, 2023 20:00
@cameronhollis cameronhollis changed the title #38769 text-bg-primary now respects --bs-primary colo #38769 text-bg-primary now respects --bs-primary color Jun 14, 2023
louismaximepiton
louismaximepiton approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

LGTM!

@mdo mdo changed the title #38769 text-bg-primary now respects --bs-primary color .text-bg-* helpers now use theme CSS variables Jul 6, 2023
@mdo mdo merged commit 7dfa9c5 into twbs:main Jul 17, 2023
15 checks passed
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@cameronhollis @cameronhollis4 @romankupchak93
.text-bg-* helpers now use theme CSS variables (twbs#38772)
1937647 
* twbs#38769 text-bg-primary now respects --bs-primary color

* Revert "twbs#38769 text-bg-primary now respects --bs-primary color"

This reverts commit a4db90f.

* twbs#38769 updated scss file to respect --bs-primary color with text-bg-primary class

---------

Co-authored-by: Cameron Hollis <cameronjhollis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
css v5
Projects
No open projects
v5.3.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

text-bg-primary does not respect --bs-primary color
5 participants
@cameronhollis @mdo @louismaximepiton @julien-deramond @cameronhollis4