Generalize disabled nav links CSS rules #38774
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most of the time, our
.nav-link
s are really links and don't need:disabled
rules. However, we provide JavaScript examples (e.g. with.nav-tabs
) where we use<button>
s that can need:disabled
rules.This PR suggest a kind of defensive approach where the disabled state is defined globally for all
.nav-link
s using.disabled
and:disabled
selectors.It allows us to remove the other rules defining the colors.
Please double-check different complex use cases to avoid any regressions since the documentation does not reflect all possibilities.
Type of changes
Checklist
npm run lint
)Live previews
Related issues
Linked to #38765 but doesn't take into account #38765 (comment)