Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip generated markup documentation #38902

Merged
merged 2 commits into from Jul 15, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jul 14, 2023

Description

This PR updates the generated tooltip markup by mentioning .bs-tooltip-auto instead of .bs-tooltip-top.

Motivation & Context

While looking at #38874 feature request, I was checking the generated markup, and it now contains only .bs-tooltip-auto. There's no more precise direction in the class after #32692. So the generated markup mentioned in the tooltip doc must be updated.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review July 14, 2023 08:43
@julien-deramond julien-deramond merged commit 8c13516 into main Jul 15, 2023
15 checks passed
@julien-deramond julien-deramond deleted the main-jd-change-markup-tooltip-doc branch July 15, 2023 05:45
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants