Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark mode rendering of Cheatsheet examples #38905

Merged
merged 1 commit into from Jul 17, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jul 15, 2023

Description

This PR fixes the dark mode rendering of Cheatsheet examples.
I chose to apply minimal changes to make it work rather well: using the body color and some grays working both in light and dark modes.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #38904

@julien-deramond julien-deramond marked this pull request as ready for review July 15, 2023 06:35
@julien-deramond julien-deramond requested a review from a team as a code owner July 15, 2023 06:35
@mdo mdo merged commit b3da789 into main Jul 17, 2023
15 checks passed
@mdo mdo deleted the main-jd-fix-dark-mode-rendering-of-cheatsheet-examples branch July 17, 2023 03:48
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Cheatsheet v5.3 not rendering correctly in dark mode
2 participants