Floating labels: fix disabled with text inside #38913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@louismaximepiton that's why I said the other day to fix your commit messages 😛
|
|
Fwiw I don’t care about commit messages haha. It’s the references PRs and issues I care more about. As long as we have that, we’re usually good :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a rule to add more specifity on disabled rule.
Add some text inside one of our exemple since it doesn't overlap anything and help for the support.
Motivation & Context
Asked by community
Type of changes
Checklist
npm run lint)Live previews
Related issues
Fixes #38731.