Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postcss plugin options #38947

Merged
merged 1 commit into from Jul 24, 2023
Merged

Fix postcss plugin options #38947

merged 1 commit into from Jul 24, 2023

Conversation

o-alquimista
Copy link
Contributor

@o-alquimista o-alquimista commented Jul 22, 2023

Description

The current configuration doesn't work. If you check the output, the vendor prefixes aren't there.

I had to change the syntax a bit. It's a tiny fix.

You can see an example of the correct syntax here and here.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Related issues

@XhmikosR
Copy link
Member

What doesn't work? Because I do see the prefixes added in our dist files.

@o-alquimista
Copy link
Contributor Author

What doesn't work? Because I do see the prefixes added in our dist files.

This section is for users wishing to integrate Bootstrap in their Webpack configuration. It's not used to generate Bootstrap dist files.

@XhmikosR
Copy link
Member

So, you are saying this here https://github.com/twbs/examples/tree/main/webpack doesn't include the prefixes, right?

If so please make a PR against the examples repo first.

@XhmikosR
Copy link
Member

On a side note, I probably mixed up the syntax in twbs/examples@a242d6f

@o-alquimista
Copy link
Contributor Author

So, you are saying this here https://github.com/twbs/examples/tree/main/webpack doesn't include the prefixes, right?

If so please make a PR against the examples repo first.

Yes. It's done.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on twbs/examples#297 (review) (verified in twbs/examples repo)

@XhmikosR XhmikosR merged commit 57ddb42 into twbs:main Jul 24, 2023
15 checks passed
@o-alquimista o-alquimista deleted the patch-1 branch July 24, 2023 20:38
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants