Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix popover template role error #38978

Merged
merged 1 commit into from Jul 29, 2023
Merged

Docs: Fix popover template role error #38978

merged 1 commit into from Jul 29, 2023

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Jul 28, 2023 •
edited

Description

I'm quite sure this should be role="tooltip" and not role="popover". There isn't a popover role but there is a tooltip one.(https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tooltip_role).. and Bootstrap 5 itself uses role="tooltip" for its popovers by default.

Motivation & Context

Fixing a bug

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@coliff
Docs: Fix popover template role error
876bf0e 
I'm quite sure this should be `role="tooltip"` and not `role="popover"`.  There isn't a popover role but there is a tooltip one.(https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tooltip_role).. and Bootstrap 5 itself uses role="tooltip" for its popovers by default.
patrickhlauke
patrickhlauke approved these changes Jul 29, 2023
View reviewed changes
Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted

@patrickhlauke patrickhlauke merged commit 92aedd1 into twbs:main Jul 29, 2023
15 checks passed
@coliff coliff deleted the patch-3 branch July 29, 2023 23:50
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@coliff @romankupchak93
Docs: Fix popover template role error (twbs#38978)
f90a9ae 
I'm quite sure this should be `role="tooltip"` and not `role="popover"`.  There isn't a popover role but there is a tooltip one.(https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tooltip_role).. and Bootstrap 5 itself uses role="tooltip" for its popovers by default.
@CGrabda CGrabda mentioned this pull request May 17, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 18, 2024
Open
@lukegeor lukegeor mentioned this pull request May 18, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 19, 2024
Open
This was referenced May 19, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 19, 2024
Open
@Identian Identian mentioned this pull request May 20, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 21, 2024
Open
@Hamberfim Hamberfim mentioned this pull request May 21, 2024
Merged
@V1CTORY360 V1CTORY360 mentioned this pull request May 22, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 23, 2024
Open
This was referenced May 24, 2024
Open
Open
@devcurt696 devcurt696 mentioned this pull request May 24, 2024
Open
@BeyondMaxim BeyondMaxim mentioned this pull request May 24, 2024
Open
@suryaelidanto suryaelidanto mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@Guiguiiz92 Guiguiiz92 mentioned this pull request May 24, 2024
Open
@Cpano Cpano mentioned this pull request May 24, 2024
Open
@zxcv32 zxcv32 mentioned this pull request May 24, 2024
Open
@rawanst rawanst mentioned this pull request May 24, 2024
Open
@V1CTORY360 V1CTORY360 mentioned this pull request May 24, 2024
Open
@ilshaad ilshaad mentioned this pull request May 24, 2024
Open
@sukhvinder-singh-166 sukhvinder-singh-166 mentioned this pull request May 24, 2024
Open
@ilshaad ilshaad mentioned this pull request May 24, 2024
Open
@BhavikDentread BhavikDentread mentioned this pull request May 24, 2024
Open
@ngochoangg ngochoangg mentioned this pull request May 24, 2024
Open
@jadsongmatos jadsongmatos mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 24, 2024
Open
@RodolfoBorbon RodolfoBorbon mentioned this pull request May 24, 2024
Open
@SherfeyInv SherfeyInv mentioned this pull request May 25, 2024
Open
@Avneesh-Rajput Avneesh-Rajput mentioned this pull request May 25, 2024
Open
@irklva irklva mentioned this pull request May 25, 2024
Open
@Avneesh-Rajput Avneesh-Rajput mentioned this pull request May 25, 2024
Open
@NAonlines NAonlines mentioned this pull request May 25, 2024
Open
@rawanst rawanst mentioned this pull request May 25, 2024
Open
@lukegeor lukegeor mentioned this pull request May 25, 2024
Open
@arlindo0x73 arlindo0x73 mentioned this pull request May 25, 2024
Open
@theKerosen theKerosen mentioned this pull request May 25, 2024
Open
@russellcs russellcs mentioned this pull request May 25, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhlauke patrickhlauke patrickhlauke approved these changes

Assignees
No one assigned
Labels
accessibility docs v5
Projects
No open projects
v5.3.2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coliff @patrickhlauke @julien-deramond