Improve change-version script #38983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
xmr/change-version
branch
from
c036755
to
088a6b4
Compare
XhmikosR
force-pushed
the
xmr/change-version
branch
from
e27dcff
to
c160cfe
Compare
XhmikosR
force-pushed
the
xmr/change-version
branch
from
c160cfe
to
d0abc77
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
XhmikosR
force-pushed
the
xmr/change-version
branch
from
d0abc77
to
e55e441
Compare
XhmikosR
force-pushed
the
xmr/change-version
branch
from
e55e441
to
10eebe2
Compare
Only replace the version in specific files instead of blindly all repo files
GeoSot
force-pushed
the
xmr/change-version
branch
from
10eebe2
to
d4792ea
Compare
GeoSot
reviewed
Aug 14, 2023
Comment on lines
+72
to
+73
| console.error(error) | ||
| process.exit(1) |
There was a problem hiding this comment.
Suggested change
| console.error(error) | |
| process.exit(1) | |
| console.error(error) | |
| process.exit(1) |
Suppose we could use throw error here, too?
| await Promise.all( | ||
| files.map(file => replaceRecursively(file, oldVersion, newVersion)) | ||
| FILES.map(file => replaceRecursively(file, oldVersion, newVersion)) |
There was a problem hiding this comment.
Do we still need the recursive replacement?
|
@GeoSot The changes are based on the script we use in bootstrap-icons: https://github.com/twbs/icons/blob/main/build/bump-version.mjs So, the plan is to keep them in sync for now. |
In this case, I think we are good to go |
GeoSot
approved these changes
Aug 14, 2023
romankupchak93
pushed a commit
to romankupchak93/bootstrap
that referenced
this pull request
Jan 5, 2024
Only replace the version in specific files instead of blindly all repo files
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only replace the version in specific files instead of blindly all repo files
EDIT: let's merge this after #38984