Tests: update navbar in visual modal test #39294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the navbar used in our modal visual test which still use old
.navbar-full
and.hidden-lg-up
classes, and so never render the content of the navbar.For context,
.hidden-lg-up
and.navbar-full
were removed after v4.0.0 alpha versions.Their usage was the following:
Corresponding code in
bootstrap.css
in v4.0.0-alpha.5that I've changed to our
.navbar-expand-lg
which does the same thing:Regarding
.navbar-full
, IMO we can just drop it as it's already handled by our.navbar-*
classes:The global modification of the navbar follows our current navbar documentation and usage.
Type of changes
Checklist
npm run lint
)Live preview