From 9d1ac2b581d22650d275b6c32a2143d36db6c3eb Mon Sep 17 00:00:00 2001 From: k-utsumi Date: Fri, 5 Jun 2020 13:52:46 +0900 Subject: [PATCH 1/3] =?UTF-8?q?=F0=9F=94=A5=20Avoid=20duplication=20of=20c?= =?UTF-8?q?ontainer=20breakpoints?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- scss/_grid.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/scss/_grid.scss b/scss/_grid.scss index 57ec5a9d0b94..770c2e9125fd 100644 --- a/scss/_grid.scss +++ b/scss/_grid.scss @@ -6,7 +6,6 @@ // Single container class with breakpoint max-widths .container { @include make-container(); - @include make-container-max-widths(); } // 100% wide container at all breakpoints From 50af0ef42ff3df4f16fb7ffce4b8b489adc5be73 Mon Sep 17 00:00:00 2001 From: k-utsumi Date: Fri, 5 Jun 2020 22:53:10 +0900 Subject: [PATCH 2/3] =?UTF-8?q?=F0=9F=94=A5=20Delete=20make-container-max-?= =?UTF-8?q?widths=20mixin?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- scss/mixins/_grid.scss | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/scss/mixins/_grid.scss b/scss/mixins/_grid.scss index b1240b01f15f..29ba741a90e0 100644 --- a/scss/mixins/_grid.scss +++ b/scss/mixins/_grid.scss @@ -10,16 +10,6 @@ margin-left: auto; } - -// For each breakpoint, define the maximum width of the container in a media query -@mixin make-container-max-widths($max-widths: $container-max-widths, $breakpoints: $grid-breakpoints) { - @each $breakpoint, $container-max-width in $max-widths { - @include media-breakpoint-up($breakpoint, $breakpoints) { - max-width: $container-max-width; - } - } -} - @mixin make-row($gutter: $grid-gutter-width) { display: flex; flex-wrap: wrap; From a7fe9dc05ad9ce4132366d842c118015cc2c5486 Mon Sep 17 00:00:00 2001 From: k-utsumi Date: Sat, 6 Jun 2020 17:08:29 +0900 Subject: [PATCH 3/3] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20More=20simplify=20buil?= =?UTF-8?q?t=20code?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- scss/_grid.scss | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/scss/_grid.scss b/scss/_grid.scss index 770c2e9125fd..0bfe5303b9f5 100644 --- a/scss/_grid.scss +++ b/scss/_grid.scss @@ -4,10 +4,7 @@ @if $enable-grid-classes { // Single container class with breakpoint max-widths - .container { - @include make-container(); - } - + .container, // 100% wide container at all breakpoints .container-fluid { @include make-container();