From 5be8a38284dcb6dd539405dd97a925364aa980f8 Mon Sep 17 00:00:00 2001 From: "Athaariq \"Eric\" Ardhiansyah" Date: Fri, 25 Sep 2020 01:28:06 +0700 Subject: [PATCH 1/3] Change to "pointing hand" cursor on hover Improves user experience (UX) by adding "pointing hand" cursor on hover. So it looks more clickable even though it functioning properly. --- scss/forms/_form-check.scss | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/scss/forms/_form-check.scss b/scss/forms/_form-check.scss index f1635780fe53..8af29e2d1eee 100644 --- a/scss/forms/_form-check.scss +++ b/scss/forms/_form-check.scss @@ -7,10 +7,12 @@ min-height: $form-check-min-height; padding-left: $form-check-padding-left; margin-bottom: $form-check-margin-bottom; + cursor: pointer; .form-check-input { float: left; margin-left: $form-check-padding-left * -1; + cursor: pointer; } } @@ -26,6 +28,7 @@ border: $form-check-input-border; appearance: none; color-adjust: exact; // Keep themed appearance for print + cursor: pointer; @include transition($form-check-transition); &[type="checkbox"] { @@ -83,6 +86,7 @@ pointer-events: none; filter: none; opacity: .5; + cursor: default; } // Use disabled attribute in addition of :disabled pseudo-class @@ -91,6 +95,7 @@ &:disabled { ~ .form-check-label { opacity: .5; + cursor: default; } } } @@ -98,6 +103,7 @@ .form-check-label { color: $form-check-label-color; cursor: $form-check-label-cursor; + cursor: pointer; } // @@ -106,6 +112,7 @@ .form-switch { padding-left: $form-switch-padding-left; + cursor: pointer; .form-check-input { width: $form-switch-width; @@ -113,6 +120,7 @@ background-image: escape-svg($form-switch-bg-image); background-position: left center; @include border-radius($form-switch-border-radius); + cursor: pointer; &:focus { background-image: escape-svg($form-switch-focus-bg-image); @@ -133,6 +141,7 @@ .form-check-inline { display: inline-block; margin-right: $form-check-inline-margin-right; + cursor: pointer; } .btn-check { From ef5d08b23165879581cada8ee74ecf2a0df1bbda Mon Sep 17 00:00:00 2001 From: "Athaariq \"Eric\" Ardhiansyah" Date: Fri, 25 Sep 2020 01:37:50 +0700 Subject: [PATCH 2/3] Lint Fix Fixed unexpected lint error. For more information about pull request, see commit: https://github.com/Thor-x86/bootstrap/commit/5be8a38284dcb6dd539405dd97a925364aa980f8#diff-31b66083b0eb8354f47334c6957c36b8 --- scss/forms/_form-check.scss | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scss/forms/_form-check.scss b/scss/forms/_form-check.scss index 8af29e2d1eee..5b0eed567ceb 100644 --- a/scss/forms/_form-check.scss +++ b/scss/forms/_form-check.scss @@ -26,9 +26,9 @@ background-position: center; background-size: contain; border: $form-check-input-border; + cursor: pointer; appearance: none; color-adjust: exact; // Keep themed appearance for print - cursor: pointer; @include transition($form-check-transition); &[type="checkbox"] { @@ -85,8 +85,8 @@ &:disabled { pointer-events: none; filter: none; - opacity: .5; cursor: default; + opacity: .5; } // Use disabled attribute in addition of :disabled pseudo-class @@ -94,8 +94,8 @@ &[disabled], &:disabled { ~ .form-check-label { - opacity: .5; cursor: default; + opacity: .5; } } } @@ -117,10 +117,10 @@ .form-check-input { width: $form-switch-width; margin-left: $form-switch-padding-left * -1; + cursor: pointer; background-image: escape-svg($form-switch-bg-image); background-position: left center; @include border-radius($form-switch-border-radius); - cursor: pointer; &:focus { background-image: escape-svg($form-switch-focus-bg-image); From b17a707fa2f5095fe9be2cbbc48adfd64e24b979 Mon Sep 17 00:00:00 2001 From: "Athaariq \"Eric\" Ardhiansyah" Date: Fri, 25 Sep 2020 01:41:20 +0700 Subject: [PATCH 3/3] Lint Fix Fixed unexpected lint error. For more information about pull request, see commit: https://github.com/Thor-x86/bootstrap/commit/5be8a38284dcb6dd539405dd97a925364aa980f8#diff-31b66083b0eb8354f47334c6957c36b8 --- scss/forms/_form-check.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scss/forms/_form-check.scss b/scss/forms/_form-check.scss index 5b0eed567ceb..d765cdef4f64 100644 --- a/scss/forms/_form-check.scss +++ b/scss/forms/_form-check.scss @@ -19,6 +19,7 @@ .form-check-input { width: $form-check-input-width; height: $form-check-input-width; + cursor: pointer; margin-top: ($line-height-base - $form-check-input-width) / 2; // line-height minus check height vertical-align: top; background-color: $form-check-input-bg; @@ -26,7 +27,6 @@ background-position: center; background-size: contain; border: $form-check-input-border; - cursor: pointer; appearance: none; color-adjust: exact; // Keep themed appearance for print @include transition($form-check-transition); @@ -83,9 +83,9 @@ } &:disabled { + cursor: default; pointer-events: none; filter: none; - cursor: default; opacity: .5; }